[Elastic Agent] Add priority to dynamic input provider mappings #22352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
exekias
reviewed
Nov 6, 2020
x-pack/elastic-agent/pkg/composable/providers/kubernetes/config.go
Outdated
Show resolved
Hide resolved
exekias
approved these changes
Nov 6, 2020
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Nov 6, 2020
…tic#22352) * Add priority to dynamic input provider mappings. * Add changelog. * Update config.go (cherry picked from commit 8b2cebb)
Merged
4 tasks
blakerouse
added a commit
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a priority to the
AddOrUpdatefunction on the communication channel for a dynamic composable input provider.Why is it important?
This is used by the composable inputs controller to sort the mappings of a provider by priority before parsing them for the generated AST configuration for the running Elastic Agent. This ensures that matching of variables in the configuration happens based on the priority so lower priority processors are used over the higher priority processors. (lower wins)
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues