-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Fix incorrect hash when upgrading agent #22322
Merged
michalpristas
merged 3 commits into
elastic:master
from
michalpristas:fix-hashing-agent
Oct 30, 2020
Merged
[Ingest Manager] Fix incorrect hash when upgrading agent #22322
michalpristas
merged 3 commits into
elastic:master
from
michalpristas:fix-hashing-agent
Oct 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
needs_backport
PR is waiting to be backported to other branches.
Team:Ingest Management
Ingest Management:beta2
Group issues for ingest management beta2
labels
Oct 30, 2020
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 30, 2020
Collaborator
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 30, 2020
[Ingest Manager] Fix incorrect hash when upgrading agent (elastic#22322)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 30, 2020
[Ingest Manager] Fix incorrect hash when upgrading agent (elastic#22322)
This was referenced Oct 30, 2020
michalpristas
added a commit
that referenced
this pull request
Oct 30, 2020
michalpristas
added a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Ingest Management:beta2
Group issues for ingest management beta2
needs_backport
PR is waiting to be backported to other branches.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For some weird special case when
elastic-agent
sha512 file contains a filename prefixed with./
e.g:
elastic agent evaluates hashes incorrectly because it just trims the filename suffix. agent does not consider
./
to be part of the filename so it suspects that hash is748e927284f8eac2f5d8724f85a3be34d271b207147024906be4d254c5ff60affc51b191b7895e53bc3a1f4d1e76ef72e97c993d10b4be4804d9d6065ffefb9e ./
instead of748e927284f8eac2f5d8724f85a3be34d271b207147024906be4d254c5ff60affc51b191b7895e53bc3a1f4d1e76ef72e97c993d10b4be4804d9d6065ffefb9e
This PR just finds a correct line in a file and takes hash which is a fixed size string anyway without trimming suffixes.
Why is it important?
Fixes: #22306
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.