Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22237 to 7.x: [Metricbeat] Remove io.time from windows #22313

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Cherry-pick #22237 to 7.x: [Metricbeat] Remove io.time from windows #22313

merged 2 commits into from
Oct 30, 2020

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Oct 30, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22237 to 7.x branch. Original message:

What does this PR do?

It looks like diskio.io.time is a unix-only field that reports an incorrect zero. We accidentally marked it as "no incorrect zero" on our massive spreadsheet of metrics inventory, so it was overlooked until now.

Why is it important?

We don't want to report "incorrect zero" metrics.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull and build on a Windows machine
  • Run the diskio metricset and insure that diskio.io.time is not reported.
  • Pull and build on linux, insure that diskio.io.time is reported.

Related issues

@fearful-symmetry
[Metricbeat] Remove io.time from windows (elastic#22237)
a1309c1 
* remove io.time from windows

* fix tests

* add changelog entry

(cherry picked from commit 77882fc)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 30, 2020
@fearful-symmetry fearful-symmetry requested a review from a team October 30, 2020 14:28
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 30, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22313 updated]

  • Start Time: 2020-10-30T14:31:33.474+0000

  • Duration: 105 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 2246
Skipped 506
Total 2752

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2246
Skipped 506
Total 2752

@fearful-symmetry fearful-symmetry merged commit 8bd10a3 into elastic:7.x Oct 30, 2020
@zube zube bot removed the [zube]: Done label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fearful-symmetry @elasticmachine @kaiyan-sheng