Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19560 to 7.x: filebeat: add SSL options to checkpoint module #21988

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 19, 2020

Cherry-pick of PR #19560 to 7.x branch. Original message:

What does this PR do?

This adds a var.input type tls, which will use tcp + tls for mutual TLS authentication.

Why is it important?

Syslog udp is plaintext and does not guarantee CIA.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

#17682
CC @P1llus @adriansr @andrewstucki

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 19, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [marc-gr commented: jenkins run tests]

  • Start Time: 2020-10-28T13:14:18.288+0000

  • Duration: 69 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 4456
Skipped 567
Total 5023

@marc-gr marc-gr requested a review from a team October 21, 2020 08:29
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* feat(firewall): add tls config

* feat(firewall): add vars to manifest

* chore(checkpoint): add tls to example

* chore(checkpoint): run mage fmt update

* cleanup(checkpoint): remove obsolete log_level

* refactor(checkpoint): move to .ssl

* chore(x-pack): revert ide fix

* chore(changelog): add f5 asm ref

* revert(changelog): remove f5 asm mod

* chore(changelog): add checkpoint tls

* chore: fix lint warnings

* Undo some changes and move docs to checkpoint

* Move changelog entry

Co-authored-by: Marc Guasch <[email protected]>
(cherry picked from commit e29c3fa)
@marc-gr marc-gr force-pushed the backport_19560_7.x branch from 48b7523 to 6504b04 Compare October 28, 2020 08:29
@marc-gr
Copy link
Contributor Author

marc-gr commented Oct 28, 2020

jenkins run tests

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4456
Skipped 567
Total 5023

@marc-gr marc-gr merged commit 400a90d into elastic:7.x Oct 28, 2020
@marc-gr marc-gr deleted the backport_19560_7.x branch October 28, 2020 14:34
@zube zube bot removed the [zube]: Done label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants