Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cgroup metrics to system/process MetricSet #2184

Merged
merged 2 commits into from
Aug 9, 2016

Conversation

andrewkroh
Copy link
Member

This adds metrics from the cpu, cpuacct, memory, and blkio cgroup subsystems. Cgroup metrics are not reported for processes that are members of the default cgroup ('/').

This adds metrics from the cpu, cpuacct, memory, and blkio cgroup subsystems. Cgroup metrics are not reported for processes that are members of the default cgroup ('/').
Path to the cgroup relative to the cgroup subsystem's
mountpoint.

- name: cfs.period.us
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to our conventions: us = microseconds

@ruflin
Copy link
Member

ruflin commented Aug 9, 2016

LGTM. I left some comments related to naming of the fields but I think that is something we can also improve up in at a later stage.

@ruflin ruflin merged commit 9d547aa into elastic:master Aug 9, 2016
@ruflin
Copy link
Member

ruflin commented Aug 9, 2016

@andrewkroh One thing I realised now looking at the code again is if we should add a config option "cgroup" to only enable the cgroup fields if it is set to true? WDYT?

@andrewkroh andrewkroh deleted the feature/mb/process-cgroup branch August 11, 2016 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants