Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][Cyberark] Fix cyberark/corepas pipeline #21643

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 7, 2020

What does this PR do?

Fixes an error in the cyberark pipeline

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 7, 2020
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wasn't aware of this changes to the rsa2elk pipeline. We should also update https://github.com/adriansr/nwdevice2filebeat/blob/master/layout/module/__module__/__fileset__/ingest/pipeline.yml.tpl and https://github.com/adriansr/nwdevice2filebeat/blob/master/layout/package/__module__/__version__/dataset/__fileset__/elasticsearch/ingest_pipeline/default.yml.tpl so as not to overwrite these changes in the future (The rsa2elk pipelines could use an autogenerated warning).

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 7, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21643 updated]

  • Start Time: 2020-10-07T15:41:09.293+0000

  • Duration: 62 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

@marc-gr marc-gr merged commit 7028e2c into elastic:master Oct 7, 2020
@marc-gr marc-gr deleted the fix_cyberark_pipeline branch October 7, 2020 16:47
marc-gr added a commit to marc-gr/beats that referenced this pull request Oct 7, 2020
@marc-gr marc-gr added the v7.11.0 label Oct 7, 2020
marc-gr added a commit to marc-gr/beats that referenced this pull request Oct 7, 2020
@marc-gr marc-gr added the v7.10.0 label Oct 7, 2020
marc-gr added a commit that referenced this pull request Oct 7, 2020
marc-gr added a commit that referenced this pull request Oct 7, 2020
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
…ci-build-label-support

* upstream/master: (60 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
…012-2.0

* upstream/master: (110 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants