Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21175 to 7.x: Some fixes in Cloud Foundry fields #21201

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Cherry-pick #21175 to 7.x: Some fixes in Cloud Foundry fields #21201

merged 2 commits into from
Sep 22, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 21, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21175 to 7.x branch. Original message:

What does this PR do?

  • Remove redundant and undocumented cloudfoundry.*.timestamp fields.
  • Add missing documentation about envelope fields.
  • Update data.json files in metricbeat module.

Why is it important?

Avoid unnecessary duplication of data and keep documentation updated.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jsoriano
Some fixes in Cloud Foundry fields (elastic#21175)
84ce4eb 
Remove redundant and undocumented `cloudfoundry.*.timestamp` fields.
Add missing documentation about envelope fields.
Update `data.json` files in metricbeat module.

(cherry picked from commit 3527264)
@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Sep 21, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 21, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21201 updated]

  • Start Time: 2020-09-22T15:06:47.764+0000

  • Duration: 64 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 6524
Skipped 525
Total 7049

@jsoriano
Copy link
Member Author

jenkins run the tests please

@jsoriano jsoriano merged commit 8985718 into elastic:7.x Sep 22, 2020
@jsoriano jsoriano deleted the backport_21175_7.x branch September 22, 2020 16:34
@jsoriano jsoriano mentioned this pull request Sep 24, 2020
Closed
@zube zube bot removed the [zube]: Done label Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @kaiyan-sheng