Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20527 to 7.x: Add metrics collection from cost explorer into aws/billing metricset #21080

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Cherry-pick #20527 to 7.x: Add metrics collection from cost explorer into aws/billing metricset #21080

merged 1 commit into from
Sep 15, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Sep 14, 2020

Cherry-pick of PR #20527 to 7.x branch. Original message:

What does this PR do?

This PR is to add metrics collection from cost explorer into aws/billing metricset.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Enable aws module with ./metricbeat modules enable aws
  2. Edit aws config file modules.d/aws.yml to:
- module: aws
  period: 24h
  metricsets:
    - billing
  credential_profile_name: elastic-beats
  cost_explorer_config:
    group_by_dimension_keys:
      - "AZ"
      - "INSTANCE_TYPE"
      - "SERVICE"
    group_by_tag_keys:
      - "aws:createdBy"
  1. Run metricbeat ./metricbeat -e
  2. You should be able to see data in billing dashboard

Screenshots

Screen Shot 2020-08-25 at 3 22 31 PM (2)

Related issues

…20527)

* Add cost metricset for aws module
* Add cost_explorer_config for billing metricset with group_by_dimension_keys and group_by_tag_keys

(cherry picked from commit a0f8041)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Sep 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 14, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 14, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21080 opened]

  • Start Time: 2020-09-14T18:52:46.116+0000

  • Duration: 60 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 3587
Skipped 798
Total 4385

@kaiyan-sheng kaiyan-sheng merged commit 0d0a8cb into elastic:7.x Sep 15, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_20527_7.x branch September 15, 2020 13:27
@zube zube bot removed the [zube]: Done label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants