Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling missing counters in application_pool metricset #21071

Merged
merged 23 commits into from
Sep 17, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Sep 14, 2020

What does this PR do?

Mhe missing performance counters in the application_pool metricset would trigger an error and stop it.

Why is it important?

There should only be an error message if this is the case but should not stop the metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 14, 2020
@narph narph self-assigned this Sep 14, 2020
@narph narph added [zube]: In Review Team:Integrations Label for the Integrations team labels Sep 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 14, 2020
@narph narph added the needs_backport PR is waiting to be backported to other branches. label Sep 14, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 14, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21071 updated]

  • Start Time: 2020-09-14T12:27:07.300+0000

  • Duration: 52 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 813
Skipped 72
Total 885

@narph narph merged commit bdfff66 into elastic:master Sep 17, 2020
@narph narph deleted the iis-app branch September 17, 2020 09:44
narph added a commit to narph/beats that referenced this pull request Sep 17, 2020
* mofidy doc

* fix

* changelog

(cherry picked from commit bdfff66)
narph added a commit to narph/beats that referenced this pull request Sep 17, 2020
* mofidy doc

* fix

* changelog

(cherry picked from commit bdfff66)
narph added a commit that referenced this pull request Sep 17, 2020
)

* mofidy doc

* fix

* changelog

(cherry picked from commit bdfff66)
narph added a commit that referenced this pull request Sep 17, 2020
…ool metricset (#21132)

* Handling missing counters in application_pool metricset  (#21071)

* mofidy doc

* fix

* changelog

(cherry picked from commit bdfff66)

* fix chnagelog
v1v added a commit to v1v/beats that referenced this pull request Sep 18, 2020
…ne-2.0

* upstream/master:
  Add Cloud Foundry dashboards for metricbeat (elastic#21124)
  [Metricbeat][Kibana] Apply backoff when errored at getting usage stats (elastic#20772)
  Update input-log.asciidoc (elastic#20965) (elastic#21153)
  Remove redirects page (elastic#19574)
  [Ingest Manager] Fixed input types for filebeat (elastic#21131)
  docs: add beat specific install widget (elastic#21050)
  docs: link to APM privs for API keys (elastic#20911)
  Fix index out of range error when getting AWS account name (elastic#21101)
  Agent info docs and ci test pr (elastic#19805)
  Handling missing counters in application_pool metricset  (elastic#21071)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ation_pool metricset (elastic#21132)

* Handling missing counters in application_pool metricset  (elastic#21071)

* mofidy doc

* fix

* changelog

(cherry picked from commit d2dbc78)

* fix chnagelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants