Cherry-pick #20973 to 7.x: [Filebeat][suricata] Map x509 for suricata/eve fileset #21018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
leehinman
requested changes
Sep 8, 2020
CHANGELOG.next.asciidoc
Outdated
Comment on lines
639
to
643
| - Improve Fortinet firewall module with `x509` ECS mappings {pull}20983[20983] | ||
| - Improve Santa module with `x509` ECS mappings {pull}20976[20976] |
There was a problem hiding this comment.
Looks like cherry_pick script picked up extra Changelog lines
* Map x509 for suricata/eve fileset * Fix not_before condition and bump ecs version (cherry picked from commit 70d6bde)
marc-gr
force-pushed
the
backport_20973_7.x
branch
from
f97e003
to
09eb206
Compare
leehinman
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20973 to 7.x branch. Original message:
What does this PR do?
Maps new ecs x509 fields for suricata eve fileset.
I changed the sample test logs values for
tls.issuerandtls.subjectfollowing the examples that are shown in https://suricata.readthedocs.io/en/suricata-4.1.4/output/eve/eve-json-format.html#event-type-tls.LMK if the previous ones were also correct since I could not find any examples in suricata docs that followed that format.
Why is it important?
To keep our modules up to date with ecs 1.6
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues