Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20926 to 7.x: Use go install to install tools from go modules #20995

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 4, 2020

Cherry-pick of PR #20926 to 7.x branch. Original message:

The issue found in #20856 (comment) seems to indicate that we are still not pinning some tool. Taking a look to that I have seen that we are still installing some tools with go get, this updates go.mod to the latest version, what can lead to uncontrolled results. go install installs the version specified in go.mod, without updating it. We are already installing other tools with go install.

@jsoriano jsoriano added [zube]: In Review backport Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team labels Sep 4, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20995 opened]

  • Start Time: 2020-09-04T21:50:03.467+0000

  • Duration: 71 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 19630
Skipped 1860
Total 21490

@jsoriano jsoriano requested a review from kvch September 5, 2020 10:22
@jsoriano jsoriano merged commit eaa988d into elastic:7.x Sep 7, 2020
@jsoriano jsoriano deleted the backport_20926_7.x branch September 7, 2020 12:05
@zube zube bot removed the [zube]: Done label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants