Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick to 7.9: Only request wildcard expansion for hidden indices if supported (#20938) #20962

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.9:

* Refactoring: inverting logic to make room for another case

* Expand hidden indices wildcards if monitored ES supports that option

* Adding CHANGELOG entry

* Fixing formatting

* Avoid unnecessary setting

* Removing unnecessary suffix existence checks

* Fixing feature version

* Add test cases to unit test

* Updating test
# Conflicts:
#	metricbeat/module/elasticsearch/index/index_test.go
@ycombinator ycombinator self-assigned this Sep 3, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 3, 2020
@ycombinator ycombinator added the Team:Services (Deprecated) Label for the former Integrations-Services team label Sep 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 3, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20962 updated]

  • Start Time: 2020-09-03T13:00:33.221+0000

  • Duration: 69 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 3135
Skipped 696
Total 3831

@ycombinator ycombinator merged commit 3e64b90 into elastic:7.9 Sep 8, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…s if supported (elastic#20938) (elastic#20962)

* Only request wildcard expansion for hidden indices if supported (elastic#20938)

* Refactoring: inverting logic to make room for another case

* Expand hidden indices wildcards if monitored ES supports that option

* Adding CHANGELOG entry

* Fixing formatting

* Avoid unnecessary setting

* Removing unnecessary suffix existence checks

* Fixing feature version

* Add test cases to unit test

* Updating test
# Conflicts:
#	metricbeat/module/elasticsearch/index/index_test.go

* Fixing CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants