Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating incomplete configurations in autodiscover #20898

Merged
merged 5 commits into from
Sep 2, 2020

Commits on Sep 1, 2020

  1. Avoid generating incomplete configurations in autodiscover

    Handle errors when configuration unpacking fails. In principle this can
    only happen when some variable is missing, because configuration has
    been previously parsed as YAML. Errors on unpacking were previously
    ignored.
    
    When a variable is missing, this is clearly logged at the debug level.
    
    This changes the behaviour, previously an incomplete configuration was
    generated on this case.
    jsoriano committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    8f5e7e4 View commit details
    Browse the repository at this point in the history
  2. Fix changelog

    jsoriano committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    98fdab6 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Configuration menu
    Copy the full SHA
    76b79bb View commit details
    Browse the repository at this point in the history
  2. Revert unnecesary change

    jsoriano committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    a83dca6 View commit details
    Browse the repository at this point in the history
  3. After returning our own error at the end of resolvers, we don't need …

    …to log it additionally
    jsoriano committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    9412722 View commit details
    Browse the repository at this point in the history