Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20811 to 7.9: Add missing country_name geo field in add host metadata #20817

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 27, 2020

Cherry-pick of PR #20811 to 7.9 branch. Original message:

What does this PR do?

Add missing country_name geo field in add_host_metadata and add_observer_metadata processors.

Why is it important?

Documentation includes this field, and it is also part of ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 27, 2020
Add `country_name` to the list of geo fields that can be added with
`add_host_metadata` and `add_observer_metadata`.

(cherry picked from commit 795c86f)
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20817 opened]

  • Start Time: 2020-08-27T10:07:14.467+0000

  • Duration: 68 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 19389
Skipped 1841
Total 21230

@jsoriano jsoriano merged commit 7eed2ff into elastic:7.9 Aug 27, 2020
@jsoriano jsoriano deleted the backport_20811_7.9 branch August 27, 2020 16:08
@zube zube bot removed the [zube]: Done label Nov 26, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
… (elastic#20817)

Add `country_name` to the list of geo fields that can be added with
`add_host_metadata` and `add_observer_metadata`.

(cherry picked from commit 34a007e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants