Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample config in the Filebeat Azure module docs #20809

Closed
wants to merge 2 commits into from
Closed

Fix sample config in the Filebeat Azure module docs #20809

wants to merge 2 commits into from

Conversation

SpencerLN
Copy link
Contributor

What does this PR do?

Fixes a small typo in the Filebeat Azure module docs where the eventhub setting was incorrect.

Why is it important?

The configuration currently provided does not function.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2020
@SpencerLN SpencerLN added the Filebeat Filebeat label Aug 26, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 26, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20809 updated]

  • Start Time: 2020-08-26T19:47:48.530+0000

  • Duration: 23 min 14 sec

leehinman
leehinman approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Aug 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2020
@andresrc andresrc added the Team:Docs Label for the Observability docs team label Aug 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@andresrc
Copy link
Contributor

Please see #20815

@kaiyan-sheng
Copy link
Contributor

Hi @SpencerLN Thanks for fixing this issue! I believe @narph already created a PR for fixing the same issue: #20815.

@SpencerLN SpencerLN closed this Sep 1, 2020
@SpencerLN SpencerLN deleted the fix-azuremodule-docs-typo branch September 1, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
bug docs Filebeat Filebeat Team:Docs Label for the Observability docs team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[filebeat] Azure Module Docs Incorrect Config Settings
5 participants
@SpencerLN @elasticmachine @andresrc @kaiyan-sheng @leehinman