Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20680 to 7.x: Change disk and network metrics to use Sum statistic method #20737

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Cherry-pick #20680 to 7.x: Change disk and network metrics to use Sum statistic method #20737

merged 1 commit into from
Aug 24, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 21, 2020

Cherry-pick of PR #20680 to 7.x branch. Original message:

What does this PR do?

This PR is to change disk and network metrics from Average to Sum statistic method. This way, the values are total in the collection period, not an average. For host inventory schema work, we identified several common host metrics and for disk and network, these metrics should be gauges, which is the total value in a period of time.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Enable aws module and change aws.yml to:
- module: aws
  period: 5m
  credential_profile_name: elastic-beats
  metricsets:
    - ec2
  1. Start Metricbeat

  2. Check metrics in Kibana and compare with CloudWatch portal with Statistic=Sum and Period=5 Minutes:

Screen Shot 2020-08-18 at 6 00 58 PM

* Change disk and network metrics to use Sum statistic method

(cherry picked from commit adeb6f3)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Aug 21, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 21, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20737 opened]

  • Start Time: 2020-08-21T18:01:35.196+0000

  • Duration: 80 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 3544
Skipped 797
Total 4341

Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 67d58e9 into elastic:7.x Aug 24, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_20680_7.x branch August 24, 2020 15:22
@zube zube bot removed the [zube]: Done label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants