Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cluster_ip field from ip to keyword #20571

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This PR changes the type of cluster_ip field of state_service metricset of kubernetes Metricbeat module from ip to keyword.

Why is it important?

cluster_ip can come with a value like None which is meaningful in Kubernetes networking. We need to change the type of this filed so as to be possible to index such values.

Related issues

@ChrsMark ChrsMark added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Platforms Label for the Integrations - Platforms team v7.10.0 labels Aug 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 12, 2020
Signed-off-by: chrismark <[email protected]>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20571 updated]

  • Start Time: 2020-08-12T13:15:37.294+0000

  • Duration: 80 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 3086
Skipped 712
Total 3798

@ChrsMark ChrsMark requested a review from jsoriano August 13, 2020 07:26
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrsMark ChrsMark merged commit 2ce0ab0 into elastic:master Aug 14, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Aug 14, 2020
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Aug 14, 2020
@kaiyan-sheng
Copy link
Contributor

Should we also backport this to 7.9 as a bug fix?

ChrsMark added a commit that referenced this pull request Aug 14, 2020
@ChrsMark
Copy link
Member Author

Should we also backport this to 7.9 as a bug fix?

I wouldn't consider it as a clear "bugfix" and hence I would prefer to not mix it with 7.9.x releases.

melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.10.0 [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state_service metricset fails on headless services
3 participants