Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20185 to 7.9: Modify doc in app_insights metricset #20363

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Cherry-pick #20185 to 7.9: Modify doc in app_insights metricset #20363

merged 2 commits into from
Jul 31, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 30, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20185 to 7.9 branch. Original message:

What does this PR do?

Updates documentation

Why is it important?

Offers example config

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 30, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 30, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20363 opened]

  • Start Time: 2020-07-30T18:24:07.450+0000

  • Duration: 24 min 26 sec

@kaiyan-sheng kaiyan-sheng merged commit d4fd150 into elastic:7.9 Jul 31, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_20185_7.9 branch July 31, 2020 13:07
@zube zube bot removed the [zube]: Done label Oct 30, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng @narph
Cherry-pick elastic#20185 to 7.9: Modify doc in app_insights metricset (
4196c19 
elastic#20363)

(cherry picked from commit aff5f2d)

Co-authored-by: Mariana Dima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @ChrsMark @narph