Add template for ssl config reference settings #20357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
6 tasks
andrewkroh
commented
Jul 30, 2020
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
urso
reviewed
Jul 30, 2020
| # this allow you to ensure that a specific certificate is used to validate the chain of trust. | ||
| # | ||
| # The pin is a base64 encoded string of the SHA-256 fingerprint. | ||
| #ssl.ca_sha256: "" |
There was a problem hiding this comment.
The commit looks somewhat bloated due to minor differences between SSL documentation. Maybe it would better to use the config from auditbeat as base for the template?
There was a problem hiding this comment.
It's bloated because the Elasticsearch output's ssl config (chosen as the source of all ssl config options) was not aligned with logstash, kafka, redis, kibana, and monitoring's config.
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
andrewkroh
force-pushed
the
feature/libbeat/ssl-config-reference-template
branch
from
fbf13b7
to
9b0b9a6
Compare
|
run tests |
1 similar comment
|
run tests |
Use a shared template for the ssl options in reference configs. The reduces duplication of the SSL settings in config templates and ensures that the reference configs are consistent across outputs and monitoring. I provided an `indent` function in case this config template needed to be reused at various indentation levels, but it turns out that all of the uses so far required an indentation of 2 (so I could have just indented ssl.reference.yml.tmpl manually).
andrewkroh
force-pushed
the
feature/libbeat/ssl-config-reference-template
branch
from
9b0b9a6
to
8725ec9
Compare
urso
approved these changes
Aug 18, 2020
6 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Aug 24, 2020
* Add template for ssl config reference settings Use a shared template for the ssl options in reference configs. The reduces duplication of the SSL settings in config templates and ensures that the reference configs are consistent across outputs and monitoring. I provided an `indent` function in case this config template needed to be reused at various indentation levels, but it turns out that all of the uses so far required an indentation of 2 (so I could have just indented ssl.reference.yml.tmpl manually). * Indent any non-whitespace containing lines (cherry picked from commit 9e4d4f2)
andrewkroh
added a commit
that referenced
this pull request
Aug 24, 2020
* Add template for ssl config reference settings Use a shared template for the ssl options in reference configs. The reduces duplication of the SSL settings in config templates and ensures that the reference configs are consistent across outputs and monitoring. I provided an `indent` function in case this config template needed to be reused at various indentation levels, but it turns out that all of the uses so far required an indentation of 2 (so I could have just indented ssl.reference.yml.tmpl manually). * Indent any non-whitespace containing lines (cherry picked from commit 9e4d4f2)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Add template for ssl config reference settings Use a shared template for the ssl options in reference configs. The reduces duplication of the SSL settings in config templates and ensures that the reference configs are consistent across outputs and monitoring. I provided an `indent` function in case this config template needed to be reused at various indentation levels, but it turns out that all of the uses so far required an indentation of 2 (so I could have just indented ssl.reference.yml.tmpl manually). * Indent any non-whitespace containing lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use a shared template for the ssl options in reference configs.
I provided an
indentfunction in case this config template needed to be reusedat various indentation levels, but it turns out that all of the uses so far required
an indentation of 2 (so I could have just indented ssl.reference.yml.tmpl manually).
Why is it important?
The reduces duplication of the SSL settings in config templates and ensures that the
reference configs are consistent across outputs and monitoring.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Related issues