feat(ci): support building docker images for PRs #20323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
mdelapenya
added
the
Team:Automation
botelastic
bot
removed
the
needs_team
v1v
approved these changes
Jul 29, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
|
.ci/packaging.groovy
Outdated
|
|
||
| def imageName = "${name}" | ||
| if (env.CHANGE_ID?.trim()) { | ||
| imageName = "${name}/pr-${env.CHANGE_ID}" |
There was a problem hiding this comment.
the image will have a mane like docker.elastic.co/observability-ci/filebeat/pr-1000:a2b3a2b3bb12b2b1212b2 for me is weird, I'd like to release docker.elastic.co/observability-ci/filebeat:a2b3a2b3bb12b2b1212b2 and docker.elastic.co/observability-ci/filebeat:pr-1000
There was a problem hiding this comment.
Agreed. I sent a commit with this change, as I see it more convenient too
mdelapenya
commented
Jul 29, 2020
| def oldName = "${DOCKER_REGISTRY}/beats/${name}:${libbetaVer}" | ||
| def newName = "${DOCKER_REGISTRY}/observability-ci/${name}:${libbetaVer}" | ||
| def newName = "${DOCKER_REGISTRY}/observability-ci/${name}:${tagName}" | ||
| def commitName = "${DOCKER_REGISTRY}/observability-ci/${name}:${env.GIT_BASE_COMMIT}" |
There was a problem hiding this comment.
We are keeping the tag with the commit
cachedout
approved these changes
Jul 29, 2020
kuisathaverat
approved these changes
Jul 29, 2020
10 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 30, 2020
…ne-2.0 * upstream/master: (29 commits) Add an explicit system test for processes on unix systems (elastic#20320) [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks (elastic#20305) [CI] Update README.md with CI references (elastic#20316) Add ECK doc links to Heartbeat docs (elastic#20284) [Filebeat] Add export tests to x-pack/filebeat (elastic#20156) feat(ci): support building docker images for PRs (elastic#20323) Update system tests dependency (elastic#20287) [Libbeat] Log debug message if the Kibana dashboard can not be imported from the archive (elastic#12211) (elastic#20150) [Filebeat][Gsuite] Transform all dates to timestamp with processor (elastic#20308) Infer types in Prometheus remote_write (elastic#19944) Remove unnecessary restarts of metricsets while using Node autodiscover (elastic#19974) docs: update changelog on master branch (elastic#20259) feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282) [CI] Change upstream reference (elastic#20296) [Filebeat] Updates to Suricata module (elastic#20220) [docs] Fix Windows download link for agent (elastic#20258) [docs] Rename release highlights to what's new (elastic#20255) fix: update the display name of the multibranch job (elastic#20265) [Elastic Agent] Add basic protocol to control Elastic Agent. (elastic#20146) Cisco ASA: Fix message 106100 (elastic#20245) ...
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Aug 6, 2020
* feat(ci): support building docker images for PRs * chore: use PR_ID as tag
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Aug 6, 2020
* feat(ci): support building docker images for PRs * chore: use PR_ID as tag
mdelapenya
added a commit
that referenced
this pull request
Aug 11, 2020
…20323) (#20468) * feat(ci): support building docker images for PRs (#20323) * feat(ci): support building docker images for PRs * chore: use PR_ID as tag * chore(ci): use build step for checking if is PR Co-authored-by: Victor Martinez <[email protected]> Co-authored-by: Victor Martinez <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Aug 11, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* feat(ci): support building docker images for PRs * chore: use PR_ID as tag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#20323) (elastic#20467) * feat(ci): support building docker images for PRs (elastic#20323) * feat(ci): support building docker images for PRs * chore: use PR_ID as tag * chore(ci): use build step for checking if is PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It uses the PR ID as the new name for the docker images built by the packaging build. This change will only apply to PRs. For any other type of build (merge, branch), the previous behavior will be kept.
Why is it important?
We want to generate images for the PRs, without overriding the current snapshot for releases. This way we will be able to consume those images for PRs in other projects, such as the e2e tests for Ingest Manager or integrations.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Use cases