Update CONTRIBUTING.md & Update Travis file to build under Go 1.5 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emirozer
changed the title
|
Oh.. I guess on Go 1.5 mongodb has issues.. Here is the Travis build : https://travis-ci.org/elastic/packetbeat/builds/76619151 |
|
It passed now. Not sure why, but that last mongodb test seems to be flaky (also with go 1.4). Thanks for the PR, we want to release the beta3 in 1-2 weeks and we're not sure yet if we want to base it on go 1.4 or 1.5. We'll merge this when we switch to 1.5. |
|
@emirozer We updated to 1.5 in the mean time. I would still like to get your change to CONTRIBUTING.md into the repo. Can you merge in master and push again? |
|
@ruflin thank you :) |
ruflin
added a commit
that referenced
this pull request
Sep 18, 2015
Update CONTRIBUTING.md & Update Travis file to build under Go 1.5
|
Merged, thx. |
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Jan 20, 2016
Update CONTRIBUTING.md & Update Travis file to build under Go 1.5
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Jan 20, 2016
Doc/update logstash output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this is necessary or not, just that a fresh clone won't run make if libpcap is missing(naturally as libpcap being the backbone of the app :) ).
Also updated the travis file to target Go 1.5 from now on