Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add x-pack role to relevant metricsets #20167

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

dedemorton
Copy link
Contributor

What does this PR do?

Adds x-pack label to docs for all metricsets that live under x-pack.

Why is it important?

The x-pack flag must appear on all topics that describe licensed functionality. This is especially critical now that the Integrations page on the website points directly to these docs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@dedemorton dedemorton added docs review needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.8.0 v7.9.0 v7.10.0 labels Jul 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 22, 2020
@botelastic
Copy link

botelastic bot commented Jul 22, 2020

This pull request doesn't have a Team:<team> label.

@dedemorton dedemorton self-assigned this Jul 22, 2020
@dedemorton dedemorton added the Metricbeat Metricbeat label Jul 22, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 22, 2020

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [dedemorton commented: jenkins run the tests please]

  • Start Time: 2020-07-23T00:36:28.796+0000

  • Duration: 71 min 30 sec

Test stats 🧪

Test Results
Failed 1
Passed 1985
Skipped 531
Total 2517

Test errors

Expand to view the tests failures

  • Name: Build and Test / Metricbeat OSS Unit tests / test_process – test_system.Test

    • Age: 1
    • Duration: 1.311
    • Error Details: False is not true : fd not found in any process events

Steps errors

Expand to view the steps failures

  • Name: Mage build unitTest
    • Description: mage build unitTest

    • Duration: 6 min 59 sec

    • Start Time: 2020-07-23T01:03:40.324+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-07-23T01:46:25.855Z] c1e54eec4b57: Download complete
[2020-07-23T01:46:26.115Z] c1e54eec4b57: Pull complete
[2020-07-23T01:46:26.115Z] Digest: sha256:b733d4a32c4da6a00a84df2ca32791bb03df95400243648d8c539e7b4cce329c
[2020-07-23T01:46:26.115Z] Status: Downloaded newer image for alpine:3.4
[2020-07-23T01:46:29.725Z] + python .ci/scripts/pre_archive_test.py
[2020-07-23T01:46:29.988Z] Copy ./metricbeat/build into build/metricbeat/build
[2020-07-23T01:46:30.000Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/build
[2020-07-23T01:46:30.024Z] Recording test results
[2020-07-23T01:46:33.820Z] Stashed 39 file(s)
[2020-07-23T01:46:33.835Z] Archiving artifacts
[2020-07-23T01:46:34.586Z] + python .ci/scripts/search_system_tests.py
[2020-07-23T01:46:34.608Z] [INFO] system-tests=''. If no empty then let's create a tarball
[2020-07-23T01:46:35.008Z] + .ci/scripts/report-codecov.sh auditbeat filebeat heartbeat journalbeat libbeat metricbeat packetbeat winlogbeat
[2020-07-23T01:46:35.008Z] + CODECOV_URL=https://codecov.io/bash
[2020-07-23T01:46:35.008Z] + '[' -e /usr/local/bin/bash_standard_lib.sh ']'
[2020-07-23T01:46:35.008Z] + source /usr/local/bin/bash_standard_lib.sh
[2020-07-23T01:46:35.008Z] ++ readonly CACHE_DIR=/var/lib/jenkins/workspace/Beats_beats_PR-20167/.git-references
[2020-07-23T01:46:35.008Z] ++ CACHE_DIR=/var/lib/jenkins/workspace/Beats_beats_PR-20167/.git-references
[2020-07-23T01:46:35.008Z] ++ declare -a cloned_git_repos
[2020-07-23T01:46:35.008Z] + retry 3 curl -sSLo codecov https://codecov.io/bash
[2020-07-23T01:46:35.008Z] + local retries=3
[2020-07-23T01:46:35.008Z] + shift
[2020-07-23T01:46:35.008Z] + local count=0
[2020-07-23T01:46:35.008Z] + curl -sSLo codecov https://codecov.io/bash
[2020-07-23T01:46:35.279Z] + return 0
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=auditbeat/build/coverage/full.cov
[2020-07-23T01:46:35.279Z] + '[' -f auditbeat/build/coverage/full.cov ']'
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=filebeat/build/coverage/full.cov
[2020-07-23T01:46:35.279Z] + '[' -f filebeat/build/coverage/full.cov ']'
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=heartbeat/build/coverage/full.cov
[2020-07-23T01:46:35.279Z] + '[' -f heartbeat/build/coverage/full.cov ']'
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=journalbeat/build/coverage/full.cov
[2020-07-23T01:46:35.279Z] + '[' -f journalbeat/build/coverage/full.cov ']'
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=libbeat/build/coverage/full.cov
[2020-07-23T01:46:35.279Z] + '[' -f libbeat/build/coverage/full.cov ']'
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=metricbeat/build/coverage/full.cov
[2020-07-23T01:46:35.279Z] + '[' -f metricbeat/build/coverage/full.cov ']'
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=packetbeat/build/coverage/full.cov
[2020-07-23T01:46:35.279Z] + '[' -f packetbeat/build/coverage/full.cov ']'
[2020-07-23T01:46:35.279Z] + for i in '"$@"'
[2020-07-23T01:46:35.279Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-07-23T01:46:35.280Z] + '[' -f winlogbeat/build/coverage/full.cov ']'
[2020-07-23T01:46:36.886Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats
[2020-07-23T01:46:37.198Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-23T01:46:37.211Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Lint
[2020-07-23T01:46:37.335Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-23T01:46:37.412Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-23T01:46:37.493Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-23T01:46:37.567Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Metricbeat-OSS-Python-Integration-tests
[2020-07-23T01:46:37.656Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests
[2020-07-23T01:46:38.033Z] + cat
[2020-07-23T01:46:38.033Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-23T01:46:38.033Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-23T01:46:44.638Z] runbld>>> runbld started
[2020-07-23T01:46:44.638Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-23T01:46:46.558Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-20167' in order of occurrence in the config (last value wins).
[2020-07-23T01:46:47.501Z] runbld>>> Debug logging enabled.
[2020-07-23T01:46:47.501Z] runbld>>> Storing result
[2020-07-23T01:46:47.765Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-23T01:46:47.765Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200723014647-9493529D
[2020-07-23T01:46:47.765Z] runbld>>> Adding system facts.
[2020-07-23T01:46:48.711Z] runbld>>> Adding vcs info for the latest commit:  12e754c35b60c1a57fcb3c099412b58fe79c1565
[2020-07-23T01:46:48.711Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-23T01:46:48.712Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-23T01:46:48.712Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-23T01:46:48.712Z] Processing JUnit reports with runbld...
[2020-07-23T01:46:48.973Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-23T01:46:48.973Z] runbld>>> DURATION: 26ms
[2020-07-23T01:46:48.973Z] runbld>>> STDOUT: 40 bytes
[2020-07-23T01:46:48.973Z] runbld>>> STDERR: 49 bytes
[2020-07-23T01:46:48.973Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-23T01:46:48.973Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats
[2020-07-23T01:46:50.359Z] runbld>>> Storing build metadata: 
[2020-07-23T01:46:50.359Z] runbld>>> Adding test report.
[2020-07-23T01:46:50.359Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats
[2020-07-23T01:46:50.945Z] runbld>>> Found 44 test output files
[2020-07-23T01:46:51.517Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-23T01:46:51.517Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20167/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-23T01:46:52.089Z] runbld>>> Test output logs contained: Errors: 0 Failures: 1 Tests: 2517 Skipped: 374
[2020-07-23T01:46:52.408Z] runbld>>> Storing result
[2020-07-23T01:46:52.408Z] runbld>>> FAILURES: 1
[2020-07-23T01:46:52.829Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-23T01:46:52.829Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200723014647-9493529D
[2020-07-23T01:46:52.829Z] runbld>>> Email notification disabled by environment variable.
[2020-07-23T01:46:52.829Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-23T01:46:58.407Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20167
[2020-07-23T01:46:58.511Z] [INFO] getVaultSecret: Getting secrets
[2020-07-23T01:46:58.589Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-23T01:46:59.414Z] + chmod 755 generate-build-data.sh
[2020-07-23T01:46:59.414Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20167/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20167/runs/2 FAILURE 4230359
[2020-07-23T01:46:59.414Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20167/runs/2/steps/?limit=10000 -o steps-info.json
[2020-07-23T01:46:59.964Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20167/runs/2/tests/?status=FAILED -o tests-errors.json
[2020-07-23T01:47:00.515Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20167/runs/2/log/ -o pipeline-log.txt

@dedemorton
Copy link
Contributor Author

jenkins run the tests please

@dedemorton dedemorton merged commit 00e14b4 into elastic:master Jul 23, 2020
@dedemorton dedemorton deleted the issue#19307 branch July 23, 2020 02:10
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Jul 23, 2020
v1v added a commit to v1v/beats that referenced this pull request Jul 27, 2020
…ne-2.0

* upstream/master: (41 commits)
  adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232)
  fix: use a fixed worker type for tests (elastic#20130)
  [Ingest Manager] Prepare packaging for endpoint and asc files (elastic#20186)
  [Packetbeat] HTTP: Improve support for 100-continue elastic#15830 (elastic#19349)
  Increase index.max_docvalue_fields_search to 200 (elastic#20218)
  [Ingest Manager] Prevent closing closed reader (elastic#20214)
  [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191)
  Testing: Ignore timestamp from cylance/protect dataset (elastic#20211)
  [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207)
  [CI] remove codecov step (elastic#20102)
  [docs] Indicate that SYSTEM user is required on Windows to use Endpoint (elastic#20172)
  Remove f5/firepass rsa2elk fileset (elastic#20160)
  [Elastic Agent] Improve GRPC stop to be more relaxed. (elastic#20118)
  Fix fileset field prefixing (elastic#20170)
  Fix terminating pod autodiscover issue (elastic#20084)
  Call host parser only once when building light metricsets (elastic#20149)
  [CI] fix null string with contains (elastic#20182)
  [Ingest Manager] Fix failing unit tests on windows (elastic#20127)
  [Filebeat] Update crowdstrike module (elastic#20138)
  [docs] Add x-pack role to relevant metricsets (elastic#20167)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add x-pack role to relevant metricsets
3 participants