Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move file metrics to dataset endpoint #19977

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

vjsamuel
Copy link
Contributor

@vjsamuel vjsamuel commented Jul 16, 2020

Breaking change

What does this PR do?

The filemetrics are on the stats endpoint. It ideally is supposed to be on /dataset similar to metricbeat. This PR moves them to the right endpoint

Why is it important?

We use stats endpoint to collect metrics. These file metrics make the endpoint to verbose.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2020
@vjsamuel vjsamuel force-pushed the move_filebeat_dataset branch 2 times, most recently from c9dfdb2 to 3a8b6e1 Compare July 16, 2020 06:48
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Jul 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2020
@vjsamuel vjsamuel force-pushed the move_filebeat_dataset branch from 3a8b6e1 to a9a5675 Compare July 17, 2020 23:26
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 17, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [urso commented: jenkins run the tests please]

  • Start Time: 2020-07-21T21:29:37.479+0000

  • Duration: 55 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 5508
Skipped 828
Total 6336

@urso
Copy link

urso commented Jul 21, 2020

This might be a breaking change.

@ycombinator Any idea if this namespace is used by monitoring?

@ycombinator
Copy link
Contributor

No, Filebeat harvester files are currently not indexed in the Filebeat monitoring indices. So they are not used by monitoring.

@urso
Copy link

urso commented Jul 21, 2020

jenkins run the tests please

@urso urso merged commit b9a00da into elastic:master Jul 22, 2020
urso pushed a commit to urso/beats that referenced this pull request Jul 22, 2020
@urso urso added the v7.10.0 label Jul 22, 2020
urso pushed a commit that referenced this pull request Jul 23, 2020
)

(cherry picked from commit b9a00da)

Co-authored-by: Vijay Samuel <[email protected]>
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@zube zube bot removed the [zube]: Done label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants