Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19929 to 7.x: [Metricbeat] Update gosigar to pass Metricbeat system tests #19934

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jul 15, 2020

Cherry-pick of PR #19929 to 7.x branch. Original message:

What does this PR do?

The system/filesystem tests are failing due to an unsafe pointer conversion. This
temporarily ignores the unsafe pointer conversion warning. Underlying pointer conversion
issue still needs addressed in gosigar.

elastic/gosigar#138

Why is it important?

The unit tests are failing for Metricbeat OSS for 7.9/7.x/master.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd elastic/beats/metricbeat/module/system/filesystem
go test -race .

Related issues

The system/filesystem tests are failing due to an unsafe pointer conversion. This
temporarily ignores the unsafe pointer conversion warning. Underlying pointer conversion
issue still needs addressed in gosigar.

elastic/gosigar#138
(cherry picked from commit d629868)
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 15, 2020
@andrewkroh andrewkroh merged commit 5c99431 into elastic:7.x Jul 15, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
@andrewkroh andrewkroh deleted the backport_19929_7.x branch January 14, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant