Cherry-pick #19459 to 7.x: [Filebeat] Fix reference leak in TCP and Unix socket inputs #19501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
[zube]: In Review
backport
Team:Services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
kaiyan-sheng
approved these changes
Jul 2, 2020
urso
approved these changes
Jul 2, 2020
andrewkroh
force-pushed
the
backport_19459_7.x
branch
from
ba9ed57 to
d73b07f
Compare
…19459) The tcp and unix input sources were leaking references causing a memory leak. When an accepted connection ended inputsource/common.Closer was supposed to delete the pointer that it held to the connection, but due to a code error `delete` was being called on the wrong map. Instead of modifying the common.Closer I replaced it with a cancellable context.Context which is designed to propagate signals from parent to children and requires less code. (cherry picked from commit 61f4846)
andrewkroh
force-pushed
the
backport_19459_7.x
branch
from
d73b07f to
bcf4477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19459 to 7.x branch. Original message:
What does this PR do?
The tcp and unix input sources were leaking references causing a memory leak.
When an accepted connection ended inputsource/common.Closer was
supposed to delete the pointer that it held to the connection, but due to a code
error
deletewas being called on the wrong map.Why is it important?
This fixes a memory leak with the tcp and unix inputs.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.