Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Handle migration of agent_info to agent in Fleet configuration #19488

Closed

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Jun 29, 2020

What does this PR do?

#19248 changed the Fleet config to use agent.id instead of agent_info.ID. This was so the configuration could match what Endpoint was expecting.

This PR handles upgrading this transparently on startup for Elastic Agent, so the agent ID will not be re-generated when upgrading to a build that includes #19243

Why is it important?

So the Agent ID is not regenerated when starting Agent after upgrading.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 29, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 29, 2020
@blakerouse blakerouse marked this pull request as ready for review June 29, 2020 13:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19488 updated]

  • Start Time: 2020-06-29T13:32:48.263+0000

  • Duration: 43 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 543
Skipped 127
Total 670

@blakerouse
Copy link
Contributor Author

Closing, going to just mark it breaking for 7.8 -> 7.9.

@blakerouse blakerouse self-assigned this Jun 29, 2020
@blakerouse blakerouse closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants