Cherry-pick #19316 to 7.8: [Filebeat][Fortinet Module] Small bugfixes for time formats and IP address arrays #19374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
leehinman
force-pushed
the
backport_19316_7.8
branch
from
a179821 to
a4ffa31
Compare
kaiyan-sheng
approved these changes
Jun 24, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
marc-gr
approved these changes
Jun 25, 2020
…dress arrays (elastic#19316) * added split for when dns is array * only fix eventtime if the time is not in seconds * added new timezone format option * new testlogs has been added * updated changelog * fixing format set for events with non timezones (cherry picked from commit 39961ad)
leehinman
force-pushed
the
backport_19316_7.8
branch
from
a4ffa31 to
dd37fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19316 to 7.8 branch. Original message:
What does this PR do?
This PR resolves reported issues around the eventtime field being in both seconds and milliseconds and that the field ipaddr can also be an array.
Why is it important?
Resolves niche usecases that would otherwise throw an error
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Added new logs and reran nosetests to ensure it was fixed.
Related issues