Cherry-pick #18973 to 7.x: Switch the GRPC communication where Agent is running the server and the beats are connecting back to Agent #19108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he beats are connecting back to Agent (elastic#18973) * Update libbeat fleet management to use elastic-agent-client. * Work on switching to the new GRPC. * More on refactor * Add back the state. * Format and check * Add changelog. * Cleanup. * mage fmt in x-pack/libbeat. * Update go.mod. * Fix from review. * Fix NewFromConfig comment * Update go.mod * Fix imports. * Fix some locking issues from review. * Fix lots of issues, add unit testing to cover restarts on failure reporting or crashes. * Update go.sum * Fix TestConfigurableRun. * Fix range over registered apps in GRPC server using RWLock, switch to sync.Map. * Fix config. * Fix tests to work on Windows. * Fix operation start to not start the same application twice. * Fix enabling and disabling of monitoring. (cherry picked from commit 0c15394)
botelastic
bot
added
the
needs_team
blakerouse
added
Team:Ingest Management
and removed
needs_team
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
michalpristas
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18973 to 7.x branch. Original message:
What does this PR do?
This completes the switch of the GRPC protocol so that the beat application will connect to Agent using the GRPC server running inside the Agent process. This uses the new protocol that allows bi-directional communication for both configuration, status, and actions.
This also completely removes the old GRPC code and protocol files, which are no longer used or needed.
Why is it important?
To only require 1 listening port on the host machine running the GRPC. To use the new
elastic-agent-clientcode to make it easier for new applications to be controlled by Agent.Checklist
I have made corresponding changes to the documentationCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs