Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ecszap version to v0.2.0 #19106

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Set ecszap version to v0.2.0 #19106

merged 2 commits into from
Jun 11, 2020

Conversation

cachedout
Copy link
Contributor

What does this PR do?

This bumps the version of ecszap from v0.1.1-0.20200424093508-cdd95a104193 to v0.2.0.

Why is it important?

This resolves a failure to download modules from a Gocenter proxy. Without this change, the following error is returned when running go mod download.

go: finding go.elastic.co/ecszap v0.1.1-0.20200424093508-cdd95a104193
go.elastic.co/[email protected]: proxy returned info for version v0.2.0 instead of requested version
exit status 1

This was happening because there is not a v0.1.1 release of ecszap. Current releases can be seen at https://github.com/elastic/ecs-logging-go-zap/releases

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Run go modules download and ensure it works.

Related issues

Use cases

Screenshots

Logs

@cachedout cachedout requested review from kvch, simitt and a team June 10, 2020 14:18
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 10, 2020
simitt
simitt reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the go.sum file also be updated to 0.2.0?

@cachedout
Copy link
Contributor Author

Shouldn't the go.sum file also be updated to 0.2.0?

I don't know what the process typically is. Since I've been testing Artifactory, I've been regularly cleaning the sum caches so I didn't face any problem with the outdated sum in my case. If this commit should contain a change to go.sum I am happy to add one but I need guidance on the right thing to do here. :)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 10, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19106 updated]

  • Start Time: 2020-06-11T09:13:55.167+0000

  • Duration: 29 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 537
Skipped 127
Total 664

@simitt
Copy link
Contributor

simitt commented Jun 10, 2020

The go.sum file should automatically be updated when updating go.mod. If it doesn't, you could run go mod tidy.

mdelapenya
mdelapenya approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the go.mod update, LGTM!

image

@urso
Copy link

urso commented Jun 10, 2020

The go.sum file should be checked in as well. It contains all known checksums for the packages in go.mod (unfortunately go.sum does never forget an entry). When downloading a dependency it's checksum is validated against go.sum. go mod verify can be used to validate the checksums against the local module cache.

@andresrc andresrc added the Team:Automation Label for the Observability productivity team label Jun 11, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 11, 2020
@cachedout
Copy link
Contributor Author

Thank you @urso and @simitt . I have now included an updated go.sum in this PR.

@cachedout
Copy link
Contributor Author

This was failing lint tests due to an error I believe may have been fixed this morning by this: #19124

I have rebased against HEAD and we'll see what happens this time. :)

@cachedout cachedout requested a review from simitt June 11, 2020 09:14
@cachedout cachedout merged commit 54da4bd into elastic:master Jun 11, 2020
v1v added a commit to v1v/beats that referenced this pull request Jun 12, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/fix-warni…
fd04fee 
…ngs-archive

* upstream/master: (119 commits)
  Update filebeat input docs (elastic#19110)
  Add ECS fields from log pipeline of PostgreSQL (elastic#19127)
  Init package libbeat/statestore (elastic#19117)
  [Ingest Manager] Retryable downloads of beats (elastic#19102)
  [DOCS] Add output.console to Functionbeat doc and Functionbeat reference file (elastic#18965)
  Add compatibility info (elastic#18929)
  Set ecszap version to v0.2.0 (elastic#19106)
  [filebeat][httpjson] Fix unit test function call (elastic#19124)
  [Filebeat][httpjson] Adds oauth2 support for httpjson input (elastic#18892)
  Allow host.* fields to be disabled in Suricata module (elastic#19107)
  Make selector string casing configurable (elastic#18854)
  Switch the GRPC communication where Agent is running the server and the beats are connecting back to Agent (elastic#18973)
  Disable host.* fields by default for netflow module (elastic#19087)
  Automatically fill zube teams on backports if available (elastic#18924)
  Fix crash on vsphere module (elastic#19078)
  [Ingest Manager] Download snapshot artifacts from snapshots repo (elastic#18685)
  [Ingest Manager] Basic Elastic Agent documentation (elastic#19030)
  Make user.id a string in system/users, in line with ECS (elastic#19019)
  [docs] Add 7.8 release highlights placeholder file (elastic#18493)
  Fix translate_sid's empty target field handling (elastic#18991)
  ...
@cachedout
Copy link
Contributor Author

Hi @urso . Given that you had to write #19161 to correct problems with this PR, I wanted to verify that when I put together a backport PR for this that it should contain both the changes found in this PR and the changes found in #19161. Is that what you had in mind?

@urso
Copy link

urso commented Jun 16, 2020

I wanted to verify that when I put together a backport PR for this that it should contain both the changes found in this PR and the changes found in #19161. Is that what you had in mind?

Yes, please.

cachedout added a commit to cachedout/beats that referenced this pull request Jun 17, 2020
@cachedout
Set ecszap version to v0.2.0 (elastic#19106)
bde884f 
* Set ecszap version to v0.2.0

* Update go.sum for go.elastic.co/ecszap v0.2.0/
@cachedout cachedout mentioned this pull request Jun 17, 2020
Merged
cachedout added a commit that referenced this pull request Jun 17, 2020
@cachedout
Cherry-pick #19106 and #19161 to 7.x: Set ecszap version to v0.2.0 &&…
6b23e5a 
… fix lint job by updating NOTICE (#19234)

* Set ecszap version to v0.2.0 (#19106)

* Set ecszap version to v0.2.0

* Update go.sum for go.elastic.co/ecszap v0.2.0/

* fix lint job by updating NOTICE (#19161)

Co-authored-by: Steffen Siering <[email protected]>
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@cachedout @melchiormoulin
Set ecszap version to v0.2.0 (elastic#19106)
80bbce8 
* Set ecszap version to v0.2.0

* Update go.sum for go.elastic.co/ecszap v0.2.0/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@v1v v1v v1v approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

@kvch kvch Awaiting requested review from kvch

Assignees
No one assigned
Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cachedout @elasticmachine @simitt @urso @mdelapenya @v1v @kuisathaverat @andresrc