Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #18327 to 7.x: [Heartbeat] Capture HTTP headers #19057

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Cherry-pick #18327 to 7.x: [Heartbeat] Capture HTTP headers #19057

merged 1 commit into from
Jun 9, 2020

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Jun 9, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18327 to 7.x branch. Original message:

Provides progress toward: elastic/uptime#190

Captures HTTP headers and stores them in the response in the same manner
as APM Server, using canonical header names in http.response.headers.
Values are not indexed, just stored, in ES.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Run the default config

@andrewvc
[Heartbeat] Capture HTTP headers (elastic#18327)
17660e7 
Provides progress toward: elastic/uptime#190

Captures HTTP headers and stores them in the response in the same manner
as APM Server, using canonical header names in `http.response.headers`.
Values are not indexed, just stored, in ES.

(cherry picked from commit af4ebe5)
@andrewvc andrewvc requested a review from a team as a code owner June 9, 2020 01:24
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2020
@andrewvc andrewvc self-assigned this Jun 9, 2020
@andrewvc andrewvc requested a review from blakerouse June 9, 2020 01:24
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19057 opened]

  • Start Time: 2020-06-09T01:25:06.536+0000

  • Duration: 54 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 315
Skipped 10
Total 325

blakerouse
blakerouse approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@andresrc andresrc added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Jun 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2020
@andrewvc andrewvc merged commit 98c5389 into elastic:7.x Jun 9, 2020
@andrewvc andrewvc deleted the backport_18327_7.x branch June 9, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@andrewvc andrewvc

Labels
backport review Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewvc @elasticmachine @blakerouse @andresrc