Add clarification about indexers/matchers in add_kubernetes_metadata #18714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
ChrsMark
added
docs
review
[zube]: In Review
Team:Platforms
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
added
needs_team
Signed-off-by: chrismark <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
|
Signed-off-by: chrismark <[email protected]>
jsoriano
approved these changes
May 25, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
May 25, 2020
…lastic#18714) (cherry picked from commit a9be1b5)
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
May 25, 2020
…lastic#18714) (cherry picked from commit a9be1b5)
ChrsMark
added a commit
that referenced
this pull request
May 26, 2020
ChrsMark
added a commit
that referenced
this pull request
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves the documentation of
add_kubernetes_metadataprocessor regarding the importance of indexers/matches in some Beats like Heartbeat.Why is it important?
Only Filebeat and Metricbeat have default indexers and matchers. A beat like Heartbeat is not able to start without defining matchers:
We need to make it clear in the docs, to avoid confusion.
cc: @exekias @david-kow