Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Change index_pattern from "" to "metricbeat-*" #18698

Merged
merged 2 commits into from
May 25, 2020
Merged

[Metricbeat] Change index_pattern from "" to "metricbeat-*" #18698

merged 2 commits into from
May 25, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

When default index is not metricbeat-* in Kibana and index_pattern is set to "", visualizations will take the default index pattern by default. If the default index pattern is not metricbeat-*, then these dashboards will fail.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 21, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 21, 2020
@kaiyan-sheng kaiyan-sheng added bug needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18698 opened]

  • Start Time: 2020-05-21T21:23:49.345+0000

  • Duration: 56 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 1196
Skipped 199
Total 1395

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Is this something we could automate/embed/document though when we export dashboards?

@kaiyan-sheng
Copy link
Contributor Author

@ChrsMark Good point, I will look into adding this to the ci check along with the rest of the dashboard related checks. It will be very helpful!

@kaiyan-sheng kaiyan-sheng merged commit 1d62f17 into elastic:master May 25, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels May 25, 2020
@kaiyan-sheng kaiyan-sheng deleted the ebs_dashboard branch May 25, 2020 18:10
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 25, 2020
kaiyan-sheng added a commit that referenced this pull request May 26, 2020
…18735)

* Change index_pattern from "" to "metricbeat-*"

(cherry picked from commit 1d62f17)
kaiyan-sheng added a commit that referenced this pull request May 26, 2020
…18734)

* Change index_pattern from "" to "metricbeat-*"

(cherry picked from commit 1d62f17)
kaiyan-sheng added a commit that referenced this pull request May 26, 2020
…18733)

* Change index_pattern from "" to "metricbeat-*"

(cherry picked from commit 1d62f17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review Team:Platforms Label for the Integrations - Platforms team v7.7.1 v7.8.0 v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants