Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang.org/x/crypto #18654

Merged
merged 3 commits into from
May 20, 2020
Merged

Update golang.org/x/crypto #18654

merged 3 commits into from
May 20, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented May 20, 2020 •
edited by andresrc
Loading

This addresses a problem with golang.org/x/crypto/ssh/terminal used as secure input under Windows (golang/go#36609).

Fixes #18649

@adriansr adriansr added bug review Team:Integrations Label for the Integrations team labels May 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 20, 2020
ChrsMark
ChrsMark approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for catching this @adriansr !

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 20, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 9214
Skipped 1542
Total 10756

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-20T17:53:29.067+0000

    • log

adriansr added 2 commits May 20, 2020 12:02
@adriansr
Update golang.org/x/crypto
ba459a8 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes elastic#18649
@adriansr
Update notice
eafb084
@adriansr adriansr force-pushed the fix_keystore_win_18649 branch from 9010e21 to eafb084 Compare May 20, 2020 10:03
@adriansr adriansr merged commit 2c90b6a into elastic:master May 20, 2020
@adriansr adriansr mentioned this pull request May 20, 2020
Merged
adriansr added a commit to adriansr/beats that referenced this pull request May 20, 2020
@adriansr
Update golang.org/x/crypto (elastic#18654)
ea9c6e9 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes elastic#18649

(cherry picked from commit 2c90b6a)
adriansr added a commit to adriansr/beats that referenced this pull request May 20, 2020
@adriansr
Update golang.org/x/crypto (elastic#18654)
2531b41 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes elastic#18649

(cherry picked from commit 2c90b6a)
@adriansr adriansr mentioned this pull request May 20, 2020
Merged
adriansr added a commit to adriansr/beats that referenced this pull request May 20, 2020
@adriansr
Update golang.org/x/crypto (elastic#18654)
c3516b5 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes elastic#18649

(cherry picked from commit 2c90b6a)
@adriansr adriansr mentioned this pull request May 20, 2020
Merged
adriansr added a commit that referenced this pull request May 21, 2020
@adriansr
Update golang.org/x/crypto (#18654) (#18670)
12ef93c 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes #18649

(cherry picked from commit 2c90b6a)
adriansr added a commit that referenced this pull request May 22, 2020
@adriansr
Update golang.org/x/crypto (#18654) (#18671)
b4ee7d9 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes #18649

(cherry picked from commit 2c90b6a)
adriansr added a commit that referenced this pull request May 22, 2020
@adriansr
Update golang.org/x/crypto (#18654) (#18673)
5dbed58 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes #18649

(cherry picked from commit 2c90b6a)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@adriansr
Update golang.org/x/crypto (elastic#18654) (elastic#18673)
342f2d7 
This addresses a problem with crypto/ssh/terminal used as secure input
under Windows.

Fixes elastic#18649

(cherry picked from commit cfccf22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
bug review Team:Integrations Label for the Integrations team v7.7.1 v7.8.0 v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[All Beats] Keystore add hangs under Windows
3 participants
@adriansr @elasticmachine @ChrsMark