[Autodiscover] Check if runner is already running before starting again #18564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
ChrsMark
added
bug
[zube]: In Review
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
|
ey @ChrsMark I think the docker-compose project is missing in the description? |
|
Also, could you add some tests? this code is quite critical as it's heavily used by autodiscover and config reload |
👍 Added |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
exekias
approved these changes
May 18, 2020
Signed-off-by: chrismark <[email protected]>
|
Wondering if this has side effects in other parts of the project since I see some Filebeat's tests failing at some CI runs: https://travis-ci.org/github/elastic/beats/jobs/687374263#L736 This change seems sane for autodiscover but not sure if the same goes for other parts that utilise this functionality 🤔 . |
|
jenkins, test this again please |
Signed-off-by: chrismark <[email protected]>
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
May 21, 2020
…in (elastic#18564) (cherry picked from commit b0f7ae7)
4 tasks
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
May 21, 2020
…in (elastic#18564) (cherry picked from commit b0f7ae7)
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes runner reload so as not to start a new runner if a runner for the same configuration is already running. This can happen in Autodiscover if we have a container queued for termination and a new one with the very same configuration. This will lead into having 2 identical configurations in reload. The first one will be skipped but the second one will create new runner while the previous is still running. This is the tricky
if/elseblock that cause this problem when we have 2 identical configurations:beats/libbeat/cfgfile/list.go
Line 73 in e990740
For more information check the related Discuss topic: https://discuss.elastic.co/t/multiple-monitoring-cycles-after-recreating-docker-image/231565/9
Why is it important?
In case of autodiscovery catches a new start event will try to start a new runner without checking if a runner is already running. This will lead in overriding the in list of runner the old one with the new one without stoping the old one. The result will be to have 2 runners running (one will be orphan and untracked).
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
./metricbeat -e -d "module,autodiscover"docker-compose up -dThere is no:
2020-05-15T08:25:01.563Z DEBUG [module] module/wrapper.go:127 Starting Wrapper[name=prometheus, len(metricSetWrappers)=1]And there is:
Related issues
Discuss: https://discuss.elastic.co/t/multiple-monitoring-cycles-after-recreating-docker-image/231565/9
This might solve #12011 too.