Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Followup to 12606 (#18316) #18520

Merged
merged 2 commits into from
May 19, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.x:

@ycombinator ycombinator added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels May 14, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 14, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 14, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 6612
Skipped 1053
Total 7665

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-18T10:34:51.056+0000

    • log

@@ -79,3 +83,5 @@ The list below covers the major changes between 7.0.0-rc2 and master only.
- Add support for MODULE environment variable in `mage goIntegTest` in metricbeat to run integration tests for a single module. {pull}17147[17147]
- Add support for a `TEST_TAGS` environment variable to add tags for tests selection following go build tags semantics, this environment variable is used by mage test targets to add build tags. Python tests can also be tagged with a decorator (`@beat.tag('sometag')`). {pull}16937[16937] {pull}17075[17075]
- Add fields validation for histogram subfields. {pull}17759[17759]
- Add IP* fields to `fields.yml` generator script in Filebeat. {issue}17998[17998] {pull}18256[18256]
- Events intended for the Elasticsearch output can now take an `op_type` metadata field of type events.OpType or string to indicate the `op_type` to use for bulk indexing. {pull}12606[12606]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this line is required AFAIC from here https://github.com/elastic/beats/pull/18316/files

* Adding developer CHANGELOG entry

* Refactoring: extracting helper method

* Adding unit tests

* Consolidate event metadata field constants

* Use events.GetMetaStringValue

* Implement op_type values as enum

* Add doc strings

* Deference event pointer

* Renaming op type consts and breaking them out into own block

* Renaming type

* Using stringer

* Using go idiom instead of if-else

* Adding default op type

* Empty string for default

* Store op type enum, not string, in event metadata

* Using events.GetMetaStringValue

* Updating dev CHANGELOG entry

* Allow for op_type metadata field to be set as either string or enum

* No need for .String()

* Handle missing key case gracefully

* Update unit tests

* Update developer CHANGELOG entry
@ycombinator ycombinator force-pushed the backport/7.x/pr-18316 branch from d47ded8 to 0ec7220 Compare May 18, 2020 09:57
@ycombinator ycombinator force-pushed the backport/7.x/pr-18316 branch from 0ec7220 to 4367248 Compare May 18, 2020 09:58
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@ycombinator ycombinator merged commit fe1a9a9 into elastic:7.x May 19, 2020
@ycombinator ycombinator deleted the backport/7.x/pr-18316 branch May 19, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants