Fix source.address not being set for nginx ingress_controller #18507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is referencing a variable that doesn't exist, presumably copied from the access pipeline definition.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
|
💚 CLA has been signed |
chendo
changed the title
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
|
@chendo thank you for reporting this and for supplying the fix! I opened a PR for this since it requires tests to be tuned accordingly. I would suggest you sign the CLA and provide me your email used in your GH account in order to add you as a co-author of this fix, wdyt? |
I've signed the CLA. My GH email is github at chen.do |
This was referenced May 15, 2020
Merged
Merged
|
@ChrsMark wow, that was fast! Thank you for making it easy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes source.address not being set on the nginx ingress_controller fileset.
This is referencing a variable that doesn't exist, presumably copied from the access pipeline definition.
PS. This is a one word change, happy for a maintainer just to make the change for me to simplify workflow.
What does this PR do?
This PR fixes the reference to the correct field for ingress_controller.
Why is it important?
Source IP is not being populated correctly, thus all the geolocation stuff won't work.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs