Update version when bulk param is available in ES stats API #18459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
needs_backport
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
the
needs_team
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
ycombinator
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
ycombinator
force-pushed
the
mb-es-index-stats-bulk-upd-version
branch
from
9e31ff4
to
70f4a75
Compare
|
run tests |
ycombinator
force-pushed
the
mb-es-index-stats-bulk-upd-version
branch
from
178b57f
to
ffcaa5f
Compare
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
May 19, 2020
ycombinator
added a commit
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the minimum version of Elasticsearch that allows the
GET _statsAPI to accept thebulkparameter.Why is it important?
Elasticsearch added the new
bulkparameter to theGET _statsAPI in elastic/elasticsearch#52208. That PR has been merged so this parameter is available inmaster/8.0.0of Elasticsearch. However, that PR has not yet been backported (see elastic/elasticsearch#55447), so this parameter is not available in earlier versions of Elasticsearch yet.So for now we tell the
elasticsearchMetricbeat module to only add thebulkparameter to theGET _statsAPI call request if the version of Elasticsearch it's talking to is 8.0.0 or higher.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksParity tests should start passing once this PR is merged.I have added an entry inThe feature that introduced this bug will be released in 7.8.0. Since that hasn't yet been released yet, no CHANGELOG entry for the bugfix is necessary.CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.