Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cmd/elastic-agent/elastic-agent.go as its not used. #18366

Merged
merged 2 commits into from
May 8, 2020
Merged

Remove cmd/elastic-agent/elastic-agent.go as its not used. #18366

merged 2 commits into from
May 8, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented May 7, 2020 •
edited
Loading

What does this PR do?

Removes cmd/elastic-agent/elastic-agent.go because main.go is the same.

Why is it important?

Removes code that is not used and confusing to have both when only one is used.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@blakerouse blakerouse self-assigned this May 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2020
@blakerouse blakerouse added enhancement and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 7, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 7, 2020 •
edited
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-08T14:51:05.251+0000

  • Duration: 124 min 7 sec (7447203)

  • Commit: a36d4e2

Log output

Expand to view the last 100 lines of log output 

[2020-05-08T16:05:20.357Z] Stage "Filebeat oss" skipped due to when conditional
[2020-05-08T16:05:20.359Z] Stage "Filebeat x-pack" skipped due to when conditional
[2020-05-08T16:05:20.360Z] Stage "Filebeat Mac OS X" skipped due to when conditional
[2020-05-08T16:05:20.360Z] Stage "Filebeat Windows" skipped due to when conditional
[2020-05-08T16:05:20.362Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-08T16:05:20.362Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:05:20.363Z] Stage "Auditbeat x-pack" skipped due to when conditional
[2020-05-08T16:05:20.364Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:05:20.365Z] Stage "Libbeat x-pack" skipped due to when conditional
[2020-05-08T16:05:20.366Z] Stage "Metricbeat OSS Unit tests" skipped due to when conditional
[2020-05-08T16:05:20.367Z] Stage "Metricbeat OSS Integration tests" skipped due to when conditional
[2020-05-08T16:05:20.368Z] Stage "Metricbeat Python integration tests" skipped due to when conditional
[2020-05-08T16:05:20.369Z] Stage "Metricbeat x-pack" skipped due to when conditional
[2020-05-08T16:05:20.370Z] Stage "Metricbeat crosscompile" skipped due to when conditional
[2020-05-08T16:05:20.389Z] Stage "Metricbeat Mac OS X" skipped due to when conditional
[2020-05-08T16:05:20.395Z] Stage "Metricbeat Windows" skipped due to when conditional
[2020-05-08T16:05:20.396Z] Stage "Packetbeat" skipped due to when conditional
[2020-05-08T16:05:20.397Z] Stage "dockerlogbeat" skipped due to when conditional
[2020-05-08T16:05:20.398Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-08T16:05:20.399Z] Stage "Winlogbeat Windows x-pack" skipped due to when conditional
[2020-05-08T16:05:20.400Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:05:20.401Z] Stage "Journalbeat" skipped due to when conditional
[2020-05-08T16:05:20.402Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:05:20.407Z] Stage "Kubernetes" skipped due to when conditional
[2020-05-08T16:05:21.598Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-08T16:05:21.599Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:05:21.600Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:05:21.601Z] Stage "Metricbeat x-pack" skipped due to when conditional
[2020-05-08T16:05:21.602Z] Stage "Packetbeat" skipped due to when conditional
[2020-05-08T16:05:21.603Z] Stage "dockerlogbeat" skipped due to when conditional
[2020-05-08T16:05:21.604Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-08T16:05:21.605Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:05:21.606Z] Stage "Journalbeat" skipped due to when conditional
[2020-05-08T16:05:21.607Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:05:24.107Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-08T16:05:24.108Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:05:24.110Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:05:24.111Z] Stage "Metricbeat x-pack" skipped due to when conditional
[2020-05-08T16:05:24.112Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-08T16:05:24.113Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:05:24.114Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:05:25.080Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-08T16:05:25.081Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:05:25.083Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:05:25.083Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:05:25.084Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:05:26.093Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:05:26.094Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:05:35.575Z] Still waiting to schedule task
[2020-05-08T16:05:35.575Z] All nodes of label ‘ubuntu&&immutable’ are offline
[2020-05-08T16:05:35.833Z] Still waiting to schedule task
[2020-05-08T16:05:35.834Z] Waiting for next available executor on ‘windows-immutable&&windows-2019’
[2020-05-08T16:05:35.837Z] Still waiting to schedule task
[2020-05-08T16:05:35.837Z] Waiting for next available executor on ‘macosx’
[2020-05-08T16:54:41.693Z] Cancelling nested steps due to timeout
[2020-05-08T16:54:44.669Z] Failed in branch Elastic Agent x-pack
[2020-05-08T16:54:44.671Z] Failed in branch Elastic Agent x-pack Windows
[2020-05-08T16:54:44.672Z] Failed in branch Elastic Agent Mac OS X
[2020-05-08T16:54:45.189Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18366/src/github.com/elastic/beats
[2020-05-08T16:54:46.178Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-08T16:54:46.359Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18366/src/github.com/elastic/beats/Lint
[2020-05-08T16:54:47.755Z] + cat
[2020-05-08T16:54:47.756Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-08T16:54:47.756Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-08T16:54:54.858Z] runbld>>> runbld started
[2020-05-08T16:54:54.858Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-05-08T16:54:55.429Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18366' in order of occurrence in the config (last value wins).
[2020-05-08T16:54:57.083Z] runbld>>> Debug logging enabled.
[2020-05-08T16:54:57.083Z] runbld>>> Storing result
[2020-05-08T16:54:57.083Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-05-08T16:54:57.083Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200508165456-B667BCEE
[2020-05-08T16:54:57.083Z] runbld>>> Adding system facts.
[2020-05-08T16:54:58.130Z] runbld>>> Adding vcs info for the latest commit:  7ec752f8385457afd3a4925976ad04c30c472129
[2020-05-08T16:54:58.130Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-05-08T16:54:58.130Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-05-08T16:54:58.130Z] Processing JUnit reports with runbld...
[2020-05-08T16:54:58.130Z] + echo 'Processing JUnit reports with runbld...'
[2020-05-08T16:54:58.564Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-05-08T16:54:58.564Z] runbld>>> DURATION: 14ms
[2020-05-08T16:54:58.564Z] runbld>>> STDOUT: 40 bytes
[2020-05-08T16:54:58.564Z] runbld>>> STDERR: 49 bytes
[2020-05-08T16:54:58.564Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-05-08T16:54:58.564Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18366/src/github.com/elastic/beats
[2020-05-08T16:54:59.571Z] runbld>>> Storing build metadata: 
[2020-05-08T16:54:59.571Z] runbld>>> Adding test report.
[2020-05-08T16:54:59.571Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18366/src/github.com/elastic/beats
[2020-05-08T16:55:00.768Z] runbld>>> Found 0 test output files
[2020-05-08T16:55:00.768Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 0 Skipped: 0
[2020-05-08T16:55:00.768Z] runbld>>> Storing result
[2020-05-08T16:55:01.115Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-05-08T16:55:01.115Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200508165456-B667BCEE
[2020-05-08T16:55:01.115Z] runbld>>> Email notification disabled by environment variable.
[2020-05-08T16:55:01.115Z] runbld>>> Slack notification disabled by environment variable.
[2020-05-08T16:55:09.418Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18366
[2020-05-08T16:55:10.023Z] [INFO] getVaultSecret: Getting secrets
[2020-05-08T16:55:10.653Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-08T16:55:12.937Z] + chmod 755 generate-build-data.sh
[2020-05-08T16:55:12.937Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18366/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18366/runs/3 ABORTED 7447203
[2020-05-08T16:55:13.848Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18366/runs/3/steps/?limit=10000 -o steps-info.json
[2020-05-08T16:55:18.106Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18366/runs/3/tests/?status=FAILED -o tests-errors.json

ph
ph approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph added [zube]: In Review elastic-agent needs_backport PR is waiting to be backported to other branches. review labels May 8, 2020
@blakerouse blakerouse merged commit 43f5689 into elastic:master May 8, 2020
@blakerouse blakerouse deleted the remove-elastic-agent-cmd branch May 8, 2020 19:13
@blakerouse blakerouse mentioned this pull request May 8, 2020
Merged
@blakerouse blakerouse added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 8, 2020
blakerouse added a commit to blakerouse/beats that referenced this pull request May 8, 2020
@blakerouse
Remove cmd/elastic-agent/elastic-agent.go as its not used. (elastic#1…
e036f06 
…8366)

* Remove cmd/elastic-agent/elastic-agent.go as its not used.

* Remove the usage of cmd/elastic-agent.

(cherry picked from commit 43f5689)
blakerouse added a commit that referenced this pull request May 8, 2020
@blakerouse
Remove cmd/elastic-agent/elastic-agent.go as its not used. (#18366) (#…
7139b74 
…18394)

* Remove cmd/elastic-agent/elastic-agent.go as its not used.

* Remove the usage of cmd/elastic-agent.

(cherry picked from commit 43f5689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees

@blakerouse blakerouse

Labels
enhancement review v7.9.0 [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakerouse @elasticmachine @ph