Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #13808 to 7.6: Fix renaming cloud metadata processor fields #18356

Merged
merged 1 commit into from
May 8, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 7, 2020

Cherry-pick of PR #13808 to 7.6 branch. Original message:

Clone the underlying metadata to allow renaming sub-fields under cloud
that are injected by the cloud metadata processor.

Without cloning the injected metadata, rename and possibly other processors fail to operate on the sub-fields of the injected cloud field.

Further details can be found in the community post: https://discuss.elastic.co/t/cannot-rename-sub-fields-of-cloud-metadata-added-via-add-cloud-metadata/201157.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2020
Clone the underlying metadata to allow renaming sub-fields under cloud
that are injected by the cloud metadata processor.

(cherry picked from commit 6785901)
@kaiyan-sheng
Copy link
Contributor

Thanks for backporting this to 7.6!

@jsoriano
Copy link
Member Author

jsoriano commented May 7, 2020

Umm, tests running in ubuntu workers have failed because it was trying to use python3 🤔 Trying to set PYTHON_EXE to python2 by default in Makefiles to see if this fixes this issue.

@jsoriano
Copy link
Member Author

jsoriano commented May 8, 2020

I am reverting the changes for python 2 and merging, there are more things that should be fixed in tests, but I don't think that this fix affects any of them.

@jsoriano jsoriano merged commit 0856169 into elastic:7.6 May 8, 2020
@jsoriano jsoriano deleted the backport_13808_7.6 branch May 8, 2020 13:21
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…#18356)

Clone the underlying metadata to allow renaming sub-fields under cloud
that are injected by the cloud metadata processor.

(cherry picked from commit 3f2565b)

Co-authored-by: Jameel Al-Aziz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants