Code

Followup to 12606#18316

Code

Merged

ycombinator merged 22 commits intoelastic:masterelastic/beats:masterfrom ycombinator:lb-followup-12606ycombinator/beats:lb-followup-12606Copy head branch name to clipboardMay 14, 2020

+312-76

Commits

Commits on May 13, 2020

• Adding developer CHANGELOG entry

  ycombinator

  committed
  a60f5fb

• Refactoring: extracting helper method

  ycombinator

  committed
  f2f3b65

• Adding unit tests

  ycombinator

  committed
  cc9c097

• Consolidate event metadata field constants

  ycombinator

  committed
  ff11264

• Use events.GetMetaStringValue

  ycombinator

  committed
  611c877

• Implement op_type values as enum

  ycombinator

  committed
  5ef7bd9

• Add doc strings

  ycombinator

  committed
  8914d75

• Deference event pointer

  ycombinator

  committed
  4d0259a

• Renaming op type consts and breaking them out into own block

  ycombinator

  committed
  fcda77d

• Renaming type

  ycombinator

  committed
  5eb058e

• Using stringer

  ycombinator

  committed
  583b42e

• Using go idiom instead of if-else

  ycombinator

  committed
  50f3ee5

• Adding default op type

  ycombinator

  committed
  8551c2c

• Empty string for default

  ycombinator

  committed
  8b1f6ea

• Store op type enum, not string, in event metadata

  ycombinator

  committed
  49acde0

• Using events.GetMetaStringValue

  ycombinator

  committed
  9b0debc

• Updating dev CHANGELOG entry

  ycombinator

  committed
  16a9eaa

• Allow for op_type metadata field to be set as either string or enum

  ycombinator

  committed
  1f4fd5d

• No need for .String()

  ycombinator

  committed
  5c02b87

• Handle missing key case gracefully

  ycombinator

  committed
  0a7e6b5

• Update unit tests

  ycombinator

  committed
  440e8c9

• Update developer CHANGELOG entry

  ycombinator

  committed
  85c6e54