[Agent] Change monitoring defaults #18226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
Team:Ingest Management
Ingest Management:beta1
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
the
needs_team
ruflin
commented
May 5, 2020
| @@ -35,7 +41,7 @@ func NewMonitor(downloadConfig *artifact.Config) *Monitor { | |||
| return &Monitor{ | |||
| operatingSystem: downloadConfig.OS(), | |||
| installPath: downloadConfig.InstallPath, | |||
| config: &monitoringConfig.MonitoringConfig{}, | |||
| config: &defaultMonitoringConfig, | |||
There was a problem hiding this comment.
@michalpristas As this introduces defaults, I wonder if we still need it to be a reference on line 35?
❕ Build Aborted
Expand to view the summary
Build stats
Log outputExpand to view the last 100 lines of log output
|
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
@ruflin Is this PR still valid? |
|
@ph I think yes, as we still rely on the defaults in config files instead of in code. @michalpristas @blakerouse Could one of you take this over? |
|
i will take a look but we are in most cases using baked-in defaults to allow empty configs (this is a recent change) will align it with proposal here |
6 tasks
|
Created new PR here: #18927 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP