Add more kubernetes integration tests #18138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
enhancement
Team:Platforms
botelastic
bot
added
the
needs_team
|
I found that I duplicated kuberemote.go in my previous branch, so that is also removed in this branch, as well as moving kubectl.go into the |
blakerouse
removed
the
needs_team
jsoriano
added
[zube]: In Review
needs_backport
|
It LGTM, but could you also change here the tag of the golang image to use |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Heck yes! I didn't know we had that function, because I was originally searching for a way to do something like that. |
jsoriano
approved these changes
Apr 30, 2020
blakerouse
force-pushed
the
more-kubernetes-testing
branch
from
fe40fde to
36da24c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
2 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
May 4, 2020
* Performing testing on kubelet metrics. * Add integration tests for kubelet, proxy, and scheduler. * mage fmt * Update to use GoVersion in pods create. * Fix kubelet hosts string to connect with kind. (cherry picked from commit 64f6e80)
blakerouse
removed
the
needs_backport
blakerouse
added a commit
that referenced
this pull request
May 4, 2020
* Performing testing on kubelet metrics. * Add integration tests for kubelet, proxy, and scheduler. * mage fmt * Update to use GoVersion in pods create. * Fix kubelet hosts string to connect with kind. (cherry picked from commit 64f6e80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds more kubernetes intergration tests for
kubelet,proxy, andschedulermetricsets.Why is it important?
For better integration test coverage for kubernetes.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
MODULE=kubernetes mage goIntegTestRelated issues