Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18091 to 7.x: Use default output by default #18119

Merged
merged 3 commits into from
May 4, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #18091 to 7.x branch. Original message:

What does this PR do?

Releases neccesity of having use_output specified with monitoring settings.
if not output is specified the one called default is used

Why is it important?

Default configurations does not state use output settings so this might be confusing

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Elastic-Agent] Use default output by default (elastic#18091)
@michalpristas michalpristas added bug backport Project:fleet Ingest Management:alpha1 Group issues for ingest management alpha1 labels Apr 30, 2020
@michalpristas michalpristas self-assigned this Apr 30, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@@ -25,6 +25,8 @@
- Fixed injected log path to monitoring beat {pull}17833[17833]
- Make sure that the Elastic Agent connect over TLS in cloud. {pull}17843[17843]
- Moved stream.* fields to top of event {pull}17858[17858]
- Fix an issue where the checkin_frequency, jitter, and backoff options where not configurable. {pull}17843[17843]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport issues?

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the changelog

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2020
@michalpristas michalpristas merged commit ea44456 into elastic:7.x May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Ingest Management:alpha1 Group issues for ingest management alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants