Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic-Agent] Configurable log level #18083

Merged
merged 10 commits into from
May 4, 2020
Merged

[Elastic-Agent] Configurable log level #18083

merged 10 commits into from
May 4, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 29, 2020 •
edited
Loading

What does this PR do?

This PR enables log level to be configurable. It even brings configuration level of agent and managed processes even.

Why is it important?

This is important for troubleshooting.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Apr 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2020
@michalpristas michalpristas requested a review from ph April 29, 2020 10:27
@michalpristas michalpristas added needs_backport PR is waiting to be backported to other branches. Team:Ingest Management and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 29, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 1795
Skipped 180
Total 1975

ph
ph approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I haven't tested it yet.

@michalpristas
Copy link
Contributor Author

need to test on windows this is troubling

@michalpristas michalpristas merged commit 2889e65 into elastic:master May 4, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 4, 2020
@michalpristas
[Elastic-Agent] Configurable log level (elastic#18083)
d478127 
* configurable log level

* changelog

* fmt

* error message updated

* windows passing

* type
@michalpristas michalpristas mentioned this pull request May 4, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request May 4, 2020
@michalpristas
[Elastic-Agent] Configurable log level (#18083) (#18191)
04117c6 
* configurable log level

* changelog

* fmt

* error message updated

* windows passing

* type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees

@michalpristas michalpristas

Labels
enhancement Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches. [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @ph