Changing field type to keyword #17978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
kaiyan-sheng
added
needs_backport
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
|
Thanks for contributing! Change looks good to me. Could you add a changelog entry under Filebeat bug fixes please? Thanks!! |
|
@kaiyan-sheng Sure, but is this really a bugfix? As it "improves" but doesn't actually fix an issue right? |
|
Good point! @exekias WDYT about the changelog? |
|
jenkins, test this please |
For now I added it under bug-fixes, let me know if it requires changing. |
|
Having it under bugfix sounds good to me! Thank you for contributing! |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
jenkins, test this please |
kaiyan-sheng
approved these changes
Apr 28, 2020
6 tasks
kaiyan-sheng
added
v7.8.0
and removed
needs_backport
6 tasks
|
Thanks for fixing this! 👍 |
kaiyan-sheng
added a commit
that referenced
this pull request
Apr 30, 2020
* Changing field type to keyword (#17978) * Changing field type to keyword * Adding changelog (cherry picked from commit 5cd6b52) * update changelog Co-authored-by: Stijn Holzhauer <[email protected]>
kaiyan-sheng
added a commit
that referenced
this pull request
Apr 30, 2020
* Changing field type to keyword (#17978) * Changing field type to keyword * Adding changelog (cherry picked from commit 5cd6b52) * update changelog Co-authored-by: Stijn Holzhauer <[email protected]>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#18093) * Changing field type to keyword (elastic#17978) * Changing field type to keyword * Adding changelog (cherry picked from commit 179c1ce) * update changelog Co-authored-by: Stijn Holzhauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify the field type from filebeat/nginx module fields from text to keyword as requested in #17834
Why is it important?
See Issue #17834
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Note
First PR ever, go easy on me ;)