Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17910 to 7.x: [Filebeat] Improve ECS field mappings in panw module #17943

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

leehinman
Copy link
Contributor

Cherry-pick of PR #17910 to 7.x branch. Original message:

What does this PR do?

Adds or changes the following fields in panw module:

  • panw.panos.action
  • event.outcome, limit to succes/failure
  • event.kind
  • event.category, make array
  • event.type, make array
  • rule.name
  • related.user

Why is it important?

Improved ECS compliance makes data more useful in SIEM app and makes correlating between data sources easier.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #16025

- panw.panos.action
- event.outcome, limit to succes/failure
- event.kind
- event.category, make array
- event.type, make array
- rule.name
- related.user

Closes elastic#16025

(cherry picked from commit e174441)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mage fmt update needs to be run in beats/filebeat. I just created a PR to fix it in master 😬 #17947

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 2107
Skipped 281
Total 2388

@leehinman leehinman merged commit 1343f66 into elastic:7.x Apr 29, 2020
@leehinman leehinman deleted the backport_17910_7.x branch April 29, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants