Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard to the azure database account metricset #17901

Merged
merged 6 commits into from
Apr 30, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Apr 22, 2020

  • Enhancement

What does this PR do?

Adds a dashboard to the azure database account metricset.
Also, removes double metricset name from the manifest.yml file

Why is it important?

It visualizes the most important database account metrics.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

databaseAccount

Update

databaseaccount1

@narph narph self-assigned this Apr 22, 2020
@narph narph added [zube]: In Review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.8.0 labels Apr 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

}
}
},
"title": "Database Account Total Requests [Metricbeat Azure]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think total request can be further split to total requests by StatusCode or Status (whichever makes more sense)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added an extra visualization which will filter on status code

"visState": {
"aggs": [],
"params": {
"controls": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it makes sense to extract DatabaseName dimension as a dedicated input. This will allow to focus the dashboard on a specific database.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the database as a filter

@narph narph requested a review from sorantis April 23, 2020 14:50
Copy link
Contributor

@sorantis sorantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narph narph merged commit 8d978f6 into elastic:master Apr 30, 2020
@narph narph deleted the add-db-dash branch April 30, 2020 10:38
narph added a commit to narph/beats that referenced this pull request Apr 30, 2020
* dashboard

* add image

* update changelog

* update dashboard

(cherry picked from commit 8d978f6)
narph added a commit that referenced this pull request May 3, 2020
* dashboard

* add image

* update changelog

* update dashboard

(cherry picked from commit 8d978f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants