Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic-Agent] missing changelog for protocol change in elastic-agent #17864

Merged
merged 1 commit into from
Apr 21, 2020
Merged

[Elastic-Agent] missing changelog for protocol change in elastic-agent #17864

merged 1 commit into from
Apr 21, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 21, 2020

We were missing a changlog entry for #17843
This PR takes care of it.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@ph ph added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Ingest Management labels Apr 21, 2020
@ph ph requested review from ruflin and michalpristas April 21, 2020 12:21
@ph ph self-assigned this Apr 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph ph added the agent label Apr 21, 2020
@ph ph changed the title missing changelog for protocol change in elastic-agent [Elastic-Agent] missing changelog for protocol change in elastic-agent Apr 21, 2020
@ph ph removed the needs_backport PR is waiting to be backported to other branches. label Apr 21, 2020
@ph
Copy link
Contributor Author

ph commented Apr 21, 2020

no need backport, already in the #17866

michalpristas
michalpristas approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ph ph merged commit e0a4a26 into elastic:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@ruflin ruflin Awaiting requested review from ruflin

Assignees

@ph ph

Labels
review [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @michalpristas