Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17344 to 7.x: [Filebeat] Improve ECS categorization field mappings in misp module. #17845

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

leehinman
Copy link
Contributor

Cherry-pick of PR #17344 to 7.x branch. Original message:

What does this PR do?

Adds following ECS fields to Filebeat misp module.

  • event.id
  • event.kind
  • registry.key if indicator type regkey
  • rule.category
  • rule.description
  • rule.id
  • rule.uuid
  • user.name if indicator type github-username

Why is it important?

Mapping to ECS improves usability in SIEM app and across data sources.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

GENERATE=true TESTING_FILEBEAT_MODULES=misp mage -v pythonIntegTest

Related issues

Closes #16026

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

)

- event.id
- event.kind
- registry.key if indicator type regkey
- rule.category
- rule.description
- rule.id
- rule.uuid
- user.name if indicator type github-username

Closes elastic#16026

(cherry picked from commit fee1f15)
@leehinman leehinman force-pushed the backport_17344_7.x branch from 9d7cdfb to 2198101 Compare April 20, 2020 20:32
@leehinman leehinman merged commit 73d8b95 into elastic:7.x Apr 21, 2020
@leehinman leehinman deleted the backport_17344_7.x branch April 21, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants