[7.x] Allow auto-configuration of Metricbeat stack modules for stack monitoring (#17609) #17772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
[zube]: In Review
backport
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
kaiyan-sheng
approved these changes
Apr 21, 2020
…ring (#17609) * Add ability to reconfigure a module * Reconfigure Logstash module with required metricsets for xpack.enabled * Replace assert with require * Adding CHANGELOG entry * Update default configuration files * Auto-configure beat module metricsets when xpack.enabled = true * Refactoring common code into helper function * Adding tests for ReConfigure() / making it part of Module interface * Moving comments * Fixing infinite recursion 🤦 * Implement for kibana module * Implementing for elasticsearch module * Moving ReConfigure method to BaseModule from Module * Fixing test function name * Use errors.Wrapf * Logging config change * Adding comment about intent of use. * s/ReConfigure/Reconfigure/ * Don't pass registry * Return copy of reconfigured module * Updating module docs to clarify auto-configuration * Fixing test * Trying out docs for `beat` module * Fixing tests * Adding tests for ReConfigure() / making it part of Module interface * Moving comments * Fixing infinite recursion 🤦 * Implement for kibana module * Implementing for elasticsearch module * Moving ReConfigure method to BaseModule from Module * Logging config change * Return copy of reconfigured module * Updating module docs to clarify auto-configuration * Fixing test * Trying out docs for `beat` module * Update metricbeat/docs/modules/beat.asciidoc Co-Authored-By: DeDe Morton <[email protected]> * Uppercasing start of log message * Updating all stack modules' docs * Reodering imports * Fixing rebase error Co-authored-by: DeDe Morton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: